Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update color variables (BDS) - 1 #1092

Merged
merged 17 commits into from
Mar 1, 2021
Merged

Update color variables (BDS) - 1 #1092

merged 17 commits into from
Mar 1, 2021

Conversation

bscofield
Copy link

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: c00e50b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 26, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/7qc4aVk9onn2MCAoJW6APvnRQ51g
✅ Preview: https://primer-components-git-bs-functional-vars-1-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview February 26, 2021 14:58 Inactive
@vercel vercel bot temporarily deployed to Preview February 26, 2021 15:27 Inactive
@vercel vercel bot temporarily deployed to Preview February 26, 2021 15:47 Inactive
@bscofield bscofield marked this pull request as ready for review February 26, 2021 17:26
colebemis
colebemis reviewed Feb 26, 2021
View reviewed changes
src/Pagehead.tsx Outdated Show resolved Hide resolved
colebemis
colebemis reviewed Feb 26, 2021
View reviewed changes
src/Caret.tsx Outdated Show resolved Hide resolved
colebemis
colebemis reviewed Feb 26, 2021
View reviewed changes
src/Popover.tsx Outdated Show resolved Hide resolved
colebemis
colebemis reviewed Feb 26, 2021
View reviewed changes
src/Popover.tsx Outdated Show resolved Hide resolved
colebemis
colebemis reviewed Feb 26, 2021
View reviewed changes
src/Popover.tsx Outdated Show resolved Hide resolved
colebemis
colebemis reviewed Feb 26, 2021
View reviewed changes
src/Popover.tsx Outdated Show resolved Hide resolved
colebemis
colebemis reviewed Feb 26, 2021
View reviewed changes
src/Popover.tsx Outdated Show resolved Hide resolved
@colebemis
Apply suggestions from code review
5869e78 
Co-authored-by: Cole Bemis <colebemis@github.com>
@vercel vercel bot temporarily deployed to Preview February 26, 2021 20:48 Inactive
@vercel vercel bot temporarily deployed to Preview February 26, 2021 20:51 Inactive
@vercel vercel bot temporarily deployed to Preview February 26, 2021 20:57 Inactive
@vercel vercel bot temporarily deployed to Preview February 26, 2021 22:25 Inactive
@vercel vercel bot temporarily deployed to Preview February 27, 2021 00:46 Inactive
@vercel vercel bot temporarily deployed to Preview February 27, 2021 00:49 Inactive
@vercel vercel bot temporarily deployed to Preview March 1, 2021 14:35 Inactive
@bscofield
Copy link
Author

https://github.com/github/design-systems/issues/1219 (x-ref)

@vercel vercel bot temporarily deployed to Preview March 1, 2021 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview March 1, 2021 17:20 Inactive
colebemis
colebemis approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@colebemis colebemis merged commit f95018b into main Mar 1, 2021
@colebemis colebemis deleted the bs-functional-vars-1 branch March 1, 2021 17:27
@github-actions github-actions bot mentioned this pull request Mar 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bscofield @colebemis