Add contrast prop to TextInput #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/ExvngBLQeeriFyF5GMZ5aXNDu2CQ |
colebemis
approved these changes
Feb 25, 2021
src/TextInput.tsx
Outdated
Comment on lines
94
to
99
| ${props => | ||
| props.contrast && | ||
| css` | ||
| background-color: ${get('colors.gray.0')}; | ||
| } | ||
| `} |
There was a problem hiding this comment.
Seems like there's one too many brackets here. It's interesting that it sill works
Suggested change
| ${props => | |
| props.contrast && | |
| css` | |
| background-color: ${get('colors.gray.0')}; | |
| } | |
| `} | |
| ${props => | |
| props.contrast && | |
| css` | |
| background-color: ${get('colors.gray.0')}; | |
| `} |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a quick addition to the TextInput as requested in #1081
Closes #1081
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
index.d.ts) if necessaryTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.