Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate FilterList to TypeScript #1015

Merged
merged 6 commits into from
Feb 4, 2021
Merged

Migrate FilterList to TypeScript #1015

merged 6 commits into from
Feb 4, 2021

Conversation

colebemis
Copy link
Contributor

This PR migrates the FilterList component to TypeScript as part of the TypeScript refactor.

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2021

🦋 Changeset detected

Latest commit: f56f781

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/gmgap84cw
✅ Preview: https://primer-components-git-cb-ts-filter-list.primer.vercel.app

@colebemis colebemis mentioned this pull request Feb 4, 2021
53 tasks
@vercel vercel bot temporarily deployed to Preview February 4, 2021 00:49 Inactive
@hehex9
Copy link
Contributor

hehex9 commented Feb 4, 2021

found a mistake in doc, it mentioned that FilterList accepts small as props but in fact that should be the props of FilterList.Item (according to the source code), just in case you missed it.

@vercel vercel bot temporarily deployed to Preview February 4, 2021 19:35 Inactive
@vercel vercel bot temporarily deployed to Preview February 4, 2021 19:43 Inactive
@colebemis
Copy link
Contributor Author

@hehex9 Good catch! Thank you ❤️

@vercel vercel bot temporarily deployed to Preview February 4, 2021 19:46 Inactive
@colebemis colebemis merged commit f8a30cc into main Feb 4, 2021
@colebemis colebemis deleted the cb/ts-filter-list branch February 4, 2021 19:53
@github-actions github-actions bot mentioned this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants