Closed
Description
Comments for handover
- Published v35.27.0 and v35.27.1
- Upgrade PR ready for dotcom, tests passing: tests passing https://github.com/github/github/pull/282818
- One round of reviews done.
- Need to test on review-lab and merge :)
This is a scheduled issue for tracking the release between Monday 31st and Friday 4th
| Last week | Value |
|---|---|
| Issue | Release Tracking |
| Conductor | joshblack |
| Release Pull Request | Link |
| Integration tests | Link |
Timeline
Monday, July 31st
- ToggleSwitch tests are now fixed in https://github.com/github/github/pull/281921
Tuesday, August 1st
- Merged a squashed version of https://github.com/github/github/pull/281921 into https://github.com/github/github/pull/282617
- Only 1 failed job, which does not seem related to primer/react: https://github.com/github/github/actions/runs/5727815798, we have seen this one be flaky on other pull requests. that is why it is not marked as required
- But, another possible problem: https://github.slack.com/archives/C02NUUQ9C30/p1690818335500569. I don't see this in the latest integration PR, will check in a codespace before ignore it
- Confirmed in codespaces that all jest tests are passing for react-code-view, including FileTree.test.tsx
- Merging Release tracking #3493 before we get more PRs in the release! Intentionally not testing on review-lab, will do that on the upgrade PR instead, which stays stable across days 😅
Wednesday, August 2nd
- Our release workflow published to npm but did not push a tag or release to github, something to debug!
- Created an upgrade workflow: https://github.com/github/github/pulls?q=is%3Aopen+is%3Apr+label%3Aprimer
- And an upgrade PR which which has 1 failing test, because of course it does: https://github.com/github/github/pull/282818
Thursday, August 3rd
Okay, we definitely know one thing that the CI did not catch:
| branch:master | branch:upgrade |
|---|---|
Sidebar in hyperlist is on the left \n |
Sidebar in hyperlist is on the right \n  |
- Need to revert [⏪ Reverted] Deprecate position prop for PageLayout.Pane, update stories and tests. #3389 in a patch release :(
Friday, August 4th
- Reverting [⏪ Reverted] Deprecate position prop for PageLayout.Pane, update stories and tests. #3389 and [⏪ Reverted] fix(PageLayout): Remove
warningfor the deprecatedpositionprop #3545 - There was already a pull request in release tracking, and it feels risky enough that I didn't want to slide it in with the hotfix. So reverting Revert "Show underline on Link when hovered or focused." #3590 as well
- Still need to debug failing tests that may or may not be related to primer.
- Fixes done! Ready for review-lab then merge
Notes
- Our release workflow published to npm but did not push a tag or release to github, something to debug!
- Still need to debug failing tests that may or may not be related to primer