Skip to content

Remove extraneous <span>s from StateLabel #232

@shawnbot

Description

@shawnbot

After reimplementing StateLabel in https://github.com/github/github/pull/96992, @jonrohan and I noticed that there's no need for the fussy <span> logic that we do for instances with icons and children. In other words, this function and this statement should go away, then this line should change to {icon}.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinggood first issueGood for newcomers

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions