Skip to content

Button display type changed from inline-block to grid changing existing arrangements. #1978

Closed
@Swiftwork

Description

@Swiftwork

Describe the bug
The new Button component has a block type display display: grid, while the old type was inline display: inline-block. Causing existing arrangements to behave differently as can be seen when using a ButtonGroup.

To Reproduce
Steps to reproduce the behavior:

<ButtonGroup>
  <Button variant="danger">Delete Session</Button>
  <Button>Share</Button>
  <Button>Save</Button>
  <Button>Publish</Button>
</ButtonGroup>

Expected behavior
One of:

  1. The Button display type is changed to an inline type such as inline-grid.
  2. ButtonGroup changes display type to inline-flex.
  3. A dynamic prop that changes such as the block.

Preference leaning towards the first alternative as this should be the most backward compatible.

Screenshots
image

Desktop (please complete the following information):

  • OS: All
  • Browser: All
  • Version: 35.0.1

Smartphone (please complete the following information):

  • Device: All
  • OS: All
  • Browser: All
  • Version: 35.0.1

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingreact

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions