Merge branch 'main' into tylerjdev/action-list-a11y-fixes

primer · May 31, 2024 · d1c1d60 · d1c1d60
2 parents 54eab93 + afe8d7a
commit d1c1d60
Show file tree

Hide file tree

Showing 105 changed files with 4,499 additions and 533 deletions.
diff --git a/.github/workflows/figma_connect_publish.yml b/.github/workflows/figma_connect_publish.yml
@@ -0,0 +1,17 @@
+name: Figma Connect Publish on Change
+
+on:
+  push:
+    paths:
+      - packages/react/src/components/**/*.figma.tsx
+    branches:
+      - main
+
+jobs:
+  code-connect:
+    name: Code Connect
+    runs-on: ubuntu-latest
+    steps:
+      - run: npx figma connect publish
+        env:
+          FIGMA_ACCESS_TOKEN: ${{ secrets.FIGMA_ACCESS_TOKEN }}
diff --git a/.github/workflows/release_tracking.yml b/.github/workflows/release_tracking.yml
@@ -14,6 +14,6 @@ on:
 jobs:
   release-tracking:
     name: Release Tracking
-    uses: primer/.github/.github/workflows/release_tracking.yml@create_release_tracking_workflow
+    uses: primer/.github/.github/workflows/release_tracking.yml@v2.1.0
     secrets:
       datadog_api_key: ${{ secrets.DATADOG_API_KEY }}
diff --git a/...ts/PageHeader.test.ts-snapshots/PageHeader-Files-Page-dark-colorblind-linux.png b/...ts/PageHeader.test.ts-snapshots/PageHeader-Files-Page-dark-colorblind-linux.png
diff --git a/...onents/PageHeader.test.ts-snapshots/PageHeader-Files-Page-dark-dimmed-linux.png b/...onents/PageHeader.test.ts-snapshots/PageHeader-Files-Page-dark-dimmed-linux.png
diff --git a/...PageHeader.test.ts-snapshots/PageHeader-Files-Page-dark-high-contrast-linux.png b/...PageHeader.test.ts-snapshots/PageHeader-Files-Page-dark-high-contrast-linux.png
diff --git a/...ts/components/PageHeader.test.ts-snapshots/PageHeader-Files-Page-dark-linux.png b/...ts/components/PageHeader.test.ts-snapshots/PageHeader-Files-Page-dark-linux.png
diff --git a/...ts/PageHeader.test.ts-snapshots/PageHeader-Files-Page-dark-tritanopia-linux.png b/...ts/PageHeader.test.ts-snapshots/PageHeader-Files-Page-dark-tritanopia-linux.png
diff --git a/...s/PageHeader.test.ts-snapshots/PageHeader-Files-Page-light-colorblind-linux.png b/...s/PageHeader.test.ts-snapshots/PageHeader-Files-Page-light-colorblind-linux.png
diff --git a/...ageHeader.test.ts-snapshots/PageHeader-Files-Page-light-high-contrast-linux.png b/...ageHeader.test.ts-snapshots/PageHeader-Files-Page-light-high-contrast-linux.png
diff --git a/...s/components/PageHeader.test.ts-snapshots/PageHeader-Files-Page-light-linux.png b/...s/components/PageHeader.test.ts-snapshots/PageHeader-Files-Page-light-linux.png
diff --git a/...s/PageHeader.test.ts-snapshots/PageHeader-Files-Page-light-tritanopia-linux.png b/...s/PageHeader.test.ts-snapshots/PageHeader-Files-Page-light-tritanopia-linux.png
diff --git a/...ts-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-dark-colorblind-linux.png b/...ts-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-dark-colorblind-linux.png
diff --git a/...est.ts-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-dark-dimmed-linux.png b/...est.ts-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-dark-dimmed-linux.png
diff --git a/...snapshots/PageHeader-Files-Page-on-Narrow-Viewport-dark-high-contrast-linux.png b/...snapshots/PageHeader-Files-Page-on-Narrow-Viewport-dark-high-contrast-linux.png
diff --git a/...eader.test.ts-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-dark-linux.png b/...eader.test.ts-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-dark-linux.png
diff --git a/...ts-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-dark-tritanopia-linux.png b/...ts-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-dark-tritanopia-linux.png
diff --git a/...s-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-light-colorblind-linux.png b/...s-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-light-colorblind-linux.png
diff --git a/...napshots/PageHeader-Files-Page-on-Narrow-Viewport-light-high-contrast-linux.png b/...napshots/PageHeader-Files-Page-on-Narrow-Viewport-light-high-contrast-linux.png
diff --git a/...ader.test.ts-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-light-linux.png b/...ader.test.ts-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-light-linux.png
diff --git a/...s-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-light-tritanopia-linux.png b/...s-snapshots/PageHeader-Files-Page-on-Narrow-Viewport-light-tritanopia-linux.png
diff --git a/...apshots/PageHeader-Large-Variant-with-Multiline-Title-dark-colorblind-linux.png b/...apshots/PageHeader-Large-Variant-with-Multiline-Title-dark-colorblind-linux.png
diff --git a/...s-snapshots/PageHeader-Large-Variant-with-Multiline-Title-dark-dimmed-linux.png b/...s-snapshots/PageHeader-Large-Variant-with-Multiline-Title-dark-dimmed-linux.png
diff --git a/...hots/PageHeader-Large-Variant-with-Multiline-Title-dark-high-contrast-linux.png b/...hots/PageHeader-Large-Variant-with-Multiline-Title-dark-high-contrast-linux.png
diff --git a/....test.ts-snapshots/PageHeader-Large-Variant-with-Multiline-Title-dark-linux.png b/....test.ts-snapshots/PageHeader-Large-Variant-with-Multiline-Title-dark-linux.png
diff --git a/...apshots/PageHeader-Large-Variant-with-Multiline-Title-dark-tritanopia-linux.png b/...apshots/PageHeader-Large-Variant-with-Multiline-Title-dark-tritanopia-linux.png
diff --git a/...pshots/PageHeader-Large-Variant-with-Multiline-Title-light-colorblind-linux.png b/...pshots/PageHeader-Large-Variant-with-Multiline-Title-light-colorblind-linux.png
diff --git a/...ots/PageHeader-Large-Variant-with-Multiline-Title-light-high-contrast-linux.png b/...ots/PageHeader-Large-Variant-with-Multiline-Title-light-high-contrast-linux.png
diff --git a/...test.ts-snapshots/PageHeader-Large-Variant-with-Multiline-Title-light-linux.png b/...test.ts-snapshots/PageHeader-Large-Variant-with-Multiline-Title-light-linux.png
diff --git a/...pshots/PageHeader-Large-Variant-with-Multiline-Title-light-tritanopia-linux.png b/...pshots/PageHeader-Large-Variant-with-Multiline-Title-light-tritanopia-linux.png
diff --git a/...Header.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-colorblind-linux.png b/...Header.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-colorblind-linux.png
diff --git a/...PageHeader.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-dimmed-linux.png b/...PageHeader.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-dimmed-linux.png
diff --git a/...der.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-high-contrast-linux.png b/...der.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-high-contrast-linux.png
diff --git a/...onents/PageHeader.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-linux.png b/...onents/PageHeader.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-linux.png
diff --git a/...Header.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-tritanopia-linux.png b/...Header.test.ts-snapshots/PageHeader-Pull-Request-Page-dark-tritanopia-linux.png
diff --git a/...eader.test.ts-snapshots/PageHeader-Pull-Request-Page-light-colorblind-linux.png b/...eader.test.ts-snapshots/PageHeader-Pull-Request-Page-light-colorblind-linux.png
diff --git a/...er.test.ts-snapshots/PageHeader-Pull-Request-Page-light-high-contrast-linux.png b/...er.test.ts-snapshots/PageHeader-Pull-Request-Page-light-high-contrast-linux.png
diff --git a/...nents/PageHeader.test.ts-snapshots/PageHeader-Pull-Request-Page-light-linux.png b/...nents/PageHeader.test.ts-snapshots/PageHeader-Pull-Request-Page-light-linux.png
diff --git a/...eader.test.ts-snapshots/PageHeader-Pull-Request-Page-light-tritanopia-linux.png b/...eader.test.ts-snapshots/PageHeader-Pull-Request-Page-light-tritanopia-linux.png
diff --git a/...shots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-colorblind-linux.png b/...shots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-colorblind-linux.png
diff --git a/...snapshots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-dimmed-linux.png b/...snapshots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-dimmed-linux.png
diff --git a/...ts/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-high-contrast-linux.png b/...ts/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-high-contrast-linux.png
diff --git a/...est.ts-snapshots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-linux.png b/...est.ts-snapshots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-linux.png
diff --git a/...shots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-tritanopia-linux.png b/...shots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-dark-tritanopia-linux.png
diff --git a/...hots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-light-colorblind-linux.png b/...hots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-light-colorblind-linux.png
diff --git a/...s/PageHeader-Pull-Request-Page-on-Narrow-Viewport-light-high-contrast-linux.png b/...s/PageHeader-Pull-Request-Page-on-Narrow-Viewport-light-high-contrast-linux.png
diff --git a/...st.ts-snapshots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-light-linux.png b/...st.ts-snapshots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-light-linux.png
diff --git a/...hots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-light-tritanopia-linux.png b/...hots/PageHeader-Pull-Request-Page-on-Narrow-Viewport-light-tritanopia-linux.png
diff --git a/...er.test.ts-snapshots/PageHeader-With-Description-Slot-dark-colorblind-linux.png b/...er.test.ts-snapshots/PageHeader-With-Description-Slot-dark-colorblind-linux.png
diff --git a/...Header.test.ts-snapshots/PageHeader-With-Description-Slot-dark-dimmed-linux.png b/...Header.test.ts-snapshots/PageHeader-With-Description-Slot-dark-dimmed-linux.png
diff --git a/...test.ts-snapshots/PageHeader-With-Description-Slot-dark-high-contrast-linux.png b/...test.ts-snapshots/PageHeader-With-Description-Slot-dark-high-contrast-linux.png
diff --git a/...ts/PageHeader.test.ts-snapshots/PageHeader-With-Description-Slot-dark-linux.png b/...ts/PageHeader.test.ts-snapshots/PageHeader-With-Description-Slot-dark-linux.png
diff --git a/...er.test.ts-snapshots/PageHeader-With-Description-Slot-dark-tritanopia-linux.png b/...er.test.ts-snapshots/PageHeader-With-Description-Slot-dark-tritanopia-linux.png
diff --git a/...r.test.ts-snapshots/PageHeader-With-Description-Slot-light-colorblind-linux.png b/...r.test.ts-snapshots/PageHeader-With-Description-Slot-light-colorblind-linux.png
diff --git a/...est.ts-snapshots/PageHeader-With-Description-Slot-light-high-contrast-linux.png b/...est.ts-snapshots/PageHeader-With-Description-Slot-light-high-contrast-linux.png
diff --git a/...s/PageHeader.test.ts-snapshots/PageHeader-With-Description-Slot-light-linux.png b/...s/PageHeader.test.ts-snapshots/PageHeader-With-Description-Slot-light-linux.png
diff --git a/...r.test.ts-snapshots/PageHeader-With-Description-Slot-light-tritanopia-linux.png b/...r.test.ts-snapshots/PageHeader-With-Description-Slot-light-tritanopia-linux.png
diff --git a/...eHeader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-colorblind-linux.png b/...eHeader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-colorblind-linux.png
diff --git a/.../PageHeader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-dimmed-linux.png b/.../PageHeader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-dimmed-linux.png
diff --git a/...ader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-high-contrast-linux.png b/...ader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-high-contrast-linux.png
diff --git a/...ponents/PageHeader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-linux.png b/...ponents/PageHeader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-linux.png
diff --git a/...eHeader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-tritanopia-linux.png b/...eHeader.test.ts-snapshots/PageHeader-With-Page-Layout-dark-tritanopia-linux.png
diff --git a/...Header.test.ts-snapshots/PageHeader-With-Page-Layout-light-colorblind-linux.png b/...Header.test.ts-snapshots/PageHeader-With-Page-Layout-light-colorblind-linux.png
diff --git a/...der.test.ts-snapshots/PageHeader-With-Page-Layout-light-high-contrast-linux.png b/...der.test.ts-snapshots/PageHeader-With-Page-Layout-light-high-contrast-linux.png
diff --git a/...onents/PageHeader.test.ts-snapshots/PageHeader-With-Page-Layout-light-linux.png b/...onents/PageHeader.test.ts-snapshots/PageHeader-With-Page-Layout-light-linux.png
diff --git a/...Header.test.ts-snapshots/PageHeader-With-Page-Layout-light-tritanopia-linux.png b/...Header.test.ts-snapshots/PageHeader-With-Page-Layout-light-tritanopia-linux.png
diff --git a/e2e/components/PageHeader.test.ts b/e2e/components/PageHeader.test.ts
@@ -673,4 +673,38 @@ test.describe('PageHeader', () => {
       })
     }
   })
+
+  test.describe('Large Variant with Multiline Title', () => {
+    for (const theme of themes) {
+      test.describe(theme, () => {
+        test('default @vrt', async ({page}) => {
+          await visit(page, {
+            id: 'drafts-components-pageheader-devonly--large-variant-with-multiline-title',
+            globals: {
+              colorScheme: theme,
+            },
+          })
+
+          // Default state
+          expect(await page.screenshot()).toMatchSnapshot(`PageHeader.Large Variant with Multiline Title.${theme}.png`)
+        })
+
+        test('axe @aat', async ({page}) => {
+          await visit(page, {
+            id: 'drafts-components-pageheader-devonly--large-variant-with-multiline-title',
+            globals: {
+              colorScheme: theme,
+            },
+          })
+          await expect(page).toHaveNoViolations({
+            rules: {
+              'color-contrast': {
+                enabled: theme !== 'dark_dimmed',
+              },
+            },
+          })
+        })
+      })
+    }
+  })
 })
diff --git a/examples/app-router/package.json b/examples/app-router/package.json
@@ -9,7 +9,7 @@
     "type-check": "tsc --noEmit"
   },
   "dependencies": {
-    "@primer/react": "36.19.0",
+    "@primer/react": "36.20.0",
     "next": "^14.1.0",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",

diff --git a/examples/codesandbox/package.json b/examples/codesandbox/package.json
@@ -20,7 +20,7 @@
     "@typescript-eslint/eslint-plugin": "^7.3.1",
     "@typescript-eslint/parser": "^7.3.1",
     "@vitejs/plugin-react": "^4.2.1",
-    "@primer/react": "36.19.0",
+    "@primer/react": "36.20.0",
     "eslint": "^8.56.0",
     "eslint-plugin-react-hooks": "^4.6.0",
     "eslint-plugin-react-refresh": "^0.4.5",

diff --git a/examples/nextjs/package.json b/examples/nextjs/package.json
@@ -10,7 +10,7 @@
   },
   "dependencies": {
     "@primer/octicons-react": "19.x",
-    "@primer/react": "36.19.0",
+    "@primer/react": "36.20.0",
     "next": "^14.1.0",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",