fix(react): update minimum version for @primer/live-region-element (#…

…4575) * fix(react): update minimum version for @primer/live-region-element * chore(deps): update lockfile and add changeset * chore: change package versions to use range * test: update test to run timers * chore: revert order change when debugging --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
primer · May 16, 2024 · b329ef5 · b329ef5
1 parent 7644ee0
commit b329ef5
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 87 deletions.
diff --git a/.changeset/bright-bees-juggle.md b/.changeset/bright-bees-juggle.md
@@ -0,0 +1,5 @@
+---
+'@primer/react': patch
+---
+
+Update minimum version for @primer/live-region-element
diff --git a/examples/app-router/package.json b/examples/app-router/package.json
@@ -9,7 +9,7 @@
     "type-check": "tsc --noEmit"
   },
   "dependencies": {
-    "@primer/react": "36.13.0",
+    "@primer/react": "36.x",
     "next": "^14.1.0",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",

diff --git a/examples/nextjs/package.json b/examples/nextjs/package.json
@@ -9,8 +9,8 @@
     "type-check": "tsc --noEmit"
   },
   "dependencies": {
-    "@primer/octicons-react": "^18.2.0",
-    "@primer/react": "36.17.0",
+    "@primer/octicons-react": "19.x",
+    "@primer/react": "36.x",
     "next": "^14.1.0",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -93,7 +93,7 @@
     "@lit-labs/react": "1.2.1",
     "@oddbird/popover-polyfill": "^0.3.1",
     "@primer/behaviors": "^1.5.1",
-    "@primer/live-region-element": "^0.2.0",
+    "@primer/live-region-element": "^0.6.1",
     "@primer/octicons-react": "^19.9.0",
     "@primer/primitives": "^7.16.0",
     "@styled-system/css": "^5.1.5",

diff --git a/packages/react/src/drafts/SelectPanel2/__tests__/SelectPanelLoading.test.tsx b/packages/react/src/drafts/SelectPanel2/__tests__/SelectPanelLoading.test.tsx
@@ -2,18 +2,22 @@ import {render} from '@testing-library/react'
 import React from 'react'
 import {SelectPanel} from '../'
 
+jest.useFakeTimers()
+
 describe('SelectPanel.Loading', () => {
   it('should announce children as a polite message', () => {
     render(<SelectPanel.Loading>test</SelectPanel.Loading>)
 
     const liveRegion = document.querySelector('live-region')!
+    jest.runAllTimers()
     expect(liveRegion.getMessage('polite')).toBe('test')
   })
 
   it('should announce a default message when no children are provided', () => {
     render(<SelectPanel.Loading />)
 
     const liveRegion = document.querySelector('live-region')!
+    jest.runAllTimers()
     expect(liveRegion.getMessage('polite')).toBe('Fetching items...')
   })
 })