SelectPanel: add role=combobox to filter input (#4977)

* add role=combobox to filter input * Create selectpanel-combobox.md
primer · Sep 23, 2024 · 97286b8 · 97286b8
1 parent 9d383c0
commit 97286b8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/green-poems-play.md b/.changeset/green-poems-play.md
@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+SelectPanel: Add `role=combobox` to filter input (behind feature flag `primer_react_select_panel_with_modern_action_list`)
diff --git a/packages/react/src/FilteredActionList/FilteredActionListWithModernActionList.tsx b/packages/react/src/FilteredActionList/FilteredActionListWithModernActionList.tsx
@@ -138,8 +138,11 @@ export function FilteredActionList({
           onChange={onInputChange}
           onKeyPress={onInputKeyPress}
           placeholder={placeholderText}
-          aria-label={placeholderText}
+          role="combobox"
+          aria-expanded="true"
+          aria-autocomplete="list"
           aria-controls={listId}
+          aria-label={placeholderText}
           aria-describedby={inputDescriptionTextId}
           {...textInputProps}
         />