Add back the eslint disables

primer · Nov 8, 2021 · 9573b82 · 9573b82
1 parent 90183a3
commit 9573b82
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/Portal/Portal.tsx b/src/Portal/Portal.tsx
@@ -90,6 +90,7 @@ export const Portal: React.FC<PortalProps> = ({children, onMount, containerName:
     return () => {
       parentElement.removeChild(element)
     }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [elementRef])
 
   return createPortal(children, elementRef.current)

diff --git a/src/hooks/useCombinedRefs.ts b/src/hooks/useCombinedRefs.ts
@@ -30,8 +30,10 @@ export function useCombinedRefs<T>(...refs: (ForwardedRef<T> | null | undefined)
 
     return () => {
       // ensure the refs get updated on unmount
+      // eslint-disable-next-line react-hooks/exhaustive-deps
       setRefs(combinedRef.current)
     }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [...refs, combinedRef.current])
 
   return combinedRef