Skip to content

Commit

Permalink
Button alignment and size bug fixes (#2652)
Browse files Browse the repository at this point in the history
* move over from major pr

* cleanup

* snippy snaps

* e2e tests

* lint?

* lint

* test(vrt): update snapshots

* Create angry-spoons-grin.md

* test(vrt): update snapshots

* counter button font-size

* test(vrt): add underlinenav snapshots

* test(vrt): update snapshots

* fix story props

* test(vrt): update snapshots

* fixing stories

* fix stories

* more cleanup

* fix input trailing action

* update docs

* lint

* snaps

* fix trailing action sizing for input

Co-authored-by: Mike Perrotti <mperrotti@users.noreply.github.com>

* Update src/Button/IconButton.tsx

Co-authored-by: Mike Perrotti <mperrotti@github.com>

* fix invisible

* Update src/Button/styles.ts

Co-authored-by: Mike Perrotti <mperrotti@github.com>

* Update src/_TextInputWrapper.tsx

Co-authored-by: Mike Perrotti <mperrotti@github.com>

* lint

* snaps

* test(vrt): update snapshots

* add back aria label

* Update angry-spoons-grin.md

* try adding back aria labels for tests

Co-authored-by: langermank <langermank@users.noreply.github.com>
Co-authored-by: joshblack <joshblack@users.noreply.github.com>
Co-authored-by: Josh Black <josh@josh.black>
Co-authored-by: Mike Perrotti <mperrotti@users.noreply.github.com>
Co-authored-by: Mike Perrotti <mperrotti@github.com>
  • Loading branch information
6 people authored Dec 20, 2022
1 parent d887586 commit 1e5f1c9
Show file tree
Hide file tree
Showing 355 changed files with 2,392 additions and 691 deletions.
10 changes: 10 additions & 0 deletions .changeset/angry-spoons-grin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"@primer/react": patch
---

- Add a block prop for full width
- Add alignContent prop to align content to center or start for full width buttons
- Use control sizing CSS variable values (not using CSS vars just yet)
- Use height over padding for more control over sizing
- Adjust invisible button variant to match new design using ActionList colors

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 1e5f1c9

Please sign in to comment.