fix: Type 'DropdownButton' as 'button' (#1318)

* fix: Type 'DropdownButton' as 'button' * chore: Update snapshots
primer · Jun 23, 2021 · 06bdde9 · 06bdde9 · vercel · Jun 23, 2021
1 parent 1d91d51
commit 06bdde9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/src/DropdownMenu/DropdownButton.tsx b/src/DropdownMenu/DropdownButton.tsx
@@ -7,7 +7,7 @@ export type DropdownButtonProps = ButtonProps
 
 export const DropdownButton = React.forwardRef<HTMLElement, React.PropsWithChildren<DropdownButtonProps>>(
   ({children, ...props}: React.PropsWithChildren<DropdownButtonProps>, ref): JSX.Element => (
-    <Button ref={ref} {...props}>
+    <Button ref={ref} type="button" {...props}>
       {children}
       <StyledOcticon icon={TriangleDownIcon} ml={1} />
     </Button>

diff --git a/src/__tests__/__snapshots__/DropdownMenu.tsx.snap b/src/__tests__/__snapshots__/DropdownMenu.tsx.snap
@@ -79,6 +79,7 @@ exports[`DropdownMenu renders consistently 1`] = `
   onClick={[Function]}
   onKeyDown={[Function]}
   tabIndex={0}
+  type="button"
 >
   <svg
     aria-hidden="true"

diff --git a/src/__tests__/__snapshots__/SelectPanel.tsx.snap b/src/__tests__/__snapshots__/SelectPanel.tsx.snap
@@ -91,6 +91,7 @@ exports[`SelectPanel renders consistently 1`] = `
     onClick={[Function]}
     onKeyDown={[Function]}
     tabIndex={0}
+    type="button"
   >
     Select Items
     <svg