Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octicon contribution for RemoveFilter #976

Merged
merged 10 commits into from
Sep 11, 2023
Merged

Octicon contribution for RemoveFilter #976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
576e084
Octicon contribution for RemoveFilter
UnicodeRogue Aug 16, 2023
7b3ef7c
taking out props
UnicodeRogue Aug 18, 2023
b5f461c
adding note about note
UnicodeRogue Aug 18, 2023
19e8220
Optimize SVGs
actions-user Aug 18, 2023
1b81847
adding 24 size version
UnicodeRogue Aug 18, 2023
a8c400a
changeset run and message added
UnicodeRogue Aug 18, 2023
cfa822b
updated snapshot for test passing
UnicodeRogue Aug 22, 2023
1179e3d
Updating filter-remove icons
CameronFoxly Sep 1, 2023
17132f0
Optimize SVGs
actions-user Sep 1, 2023
eed887c
Merge branch 'main' into 15800-SelectPanel-FilterRemove
gr2m Sep 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hip-fishes-rush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/octicons': minor
---

Adds filter remove octicon
1 change: 1 addition & 0 deletions icons/filter-remove-16.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/filter-remove-24.svg
View file
Open in desktop
Copy link
Contributor

@gr2m gr2m Aug 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the 24px SVG needs to be updated to use up the full space, right now it is still rendered as 16px with the rest being empty space. I'm not sure if there is an easy hack to upscale a 16px version? I'm sure the @primer/octicons-reviewers team will be able to help to give some pointers 🙏🏼

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I'm checking with Design!

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions keywords.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
"file-symlink-directory": ["folder", "subfolder", "link", "alias"],
"file-symlink-file": ["link", "alias"],
"file-zip": ["compress", "archive"],
"filter-remove": ["funnel", "filter", "remove", "delete"],
"fiscal-host": ["safe", "money"],
"flame": ["fire", "hot", "burn", "trending"],
"fold": ["unfold", "hide", "collapse"],
Expand Down
1 change: 1 addition & 0 deletions lib/octicons_react/__tests__/__snapshots__/public-api.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ exports[`@primer/octicons-react should not update exports without a semver chang
"FileSymlinkFileIcon",
"FileZipIcon",
"FilterIcon",
"FilterRemoveIcon",
"FiscalHostIcon",
"FlameIcon",
"FoldDownIcon",
Expand Down
Loading