Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undo / redo icons #956

Merged
merged 7 commits into from
Jun 12, 2023
Merged

Add undo / redo icons #956

merged 7 commits into from
Jun 12, 2023

Conversation

gavinmn
Copy link
Contributor

@gavinmn gavinmn commented Jun 1, 2023

@gavinmn gavinmn requested a review from a team as a code owner June 1, 2023 15:48
@gavinmn gavinmn requested a review from tallys June 1, 2023 15:48
@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

🦋 Changeset detected

Latest commit: b471d50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis
Copy link
Contributor

How do you feel about adding a little more space between the tail and the arrowhead?

CleanShot 2023-06-09 at 10 25 53@2x

Here are some under/redo icons I designed for Primer Prism that demonstrate what I mean:

CleanShot 2023-06-09 at 10 25 25@2x

@iansan5653
Copy link

iansan5653 commented Jun 9, 2023

Purely opinionated thought: Do you think maybe they are visually weighted too much toward the arrowhead? To me they kind of feel like they look like they are about to tip over, especially with a larger gap 😄. Maybe a smaller arrowhead and longer tail that goes all the way to the left?

@gavinmn
Copy link
Contributor Author

gavinmn commented Jun 9, 2023

Just pushed these changes:
CleanShot 2023-06-09 at 14 12 32@2x

I widened the radius of the turn to get some more separation between the end of the arrow and the tail. The bottom preview included is an example of the tail going further across. I feel like this causes the icon to loose the "swoop" feeling that gives the "undo" feeling and it ends up looking more like "u turn" to me.

@gavinmn gavinmn requested a review from colebemis June 9, 2023 21:20
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gavinmn gavinmn enabled auto-merge (squash) June 12, 2023 16:13
@colebemis colebemis disabled auto-merge June 12, 2023 16:34
@colebemis colebemis merged commit 16318b6 into main Jun 12, 2023
@colebemis colebemis deleted the gavinmn/undoredo branch June 12, 2023 16:34
@primer-css primer-css mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants