-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add undo / redo icons #956
Conversation
🦋 Changeset detectedLatest commit: b471d50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Purely opinionated thought: Do you think maybe they are visually weighted too much toward the arrowhead? To me they kind of feel like they look like they are about to tip over, especially with a larger gap 😄. Maybe a smaller arrowhead and longer tail that goes all the way to the left? |
I widened the radius of the turn to get some more separation between the end of the arrow and the tail. The bottom preview included is an example of the tail going further across. I feel like this causes the icon to loose the "swoop" feeling that gives the "undo" feeling and it ends up looking more like "u turn" to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
closes https://github.com/github/primer/issues/2163