Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save pin-16.svg, pin-slash-16.svg, pin-24.svg, pin-slash-24.svg #950

Merged
merged 7 commits into from
May 10, 2023

Conversation

CameronFoxly
Copy link
Contributor

This PR adds pin-slash (alt keyword unpin) and flips the orientation of our current pin icon to make them work together. Discussion in this issue.

Screen Shot 2023-05-10 at 11 34 40 AM

@CameronFoxly CameronFoxly requested a review from a team as a code owner May 10, 2023 18:44
@CameronFoxly CameronFoxly requested a review from tallys May 10, 2023 18:44
@changeset-bot
Copy link

changeset-bot bot commented May 10, 2023

🦋 Changeset detected

Latest commit: 71e0f88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis
Copy link
Contributor

@CameronFoxly I think you need to remove the frame background in Figma. When the SVG optimizer runs, the frame background turns into a black square:
CleanShot 2023-05-10 at 11 57 33@2x

@CameronFoxly
Copy link
Contributor Author

Thanks for the headsup @colebemis. Should be good now!

@colebemis colebemis merged commit 8f0edd9 into main May 10, 2023
@colebemis colebemis deleted the pin-unpin branch May 10, 2023 23:35
@primer-css primer-css mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants