Cloud icons #756
Cloud icons #756
Conversation
🦋 Changeset detectedLatest commit: 2c4380f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I'm not the biggest fan of the "overlay" in the clouds. It makes it feel a bit cartoon-y IMO. Have you tried versions without this overlap? Happy to join a working session to discuss more :) |
|
@colebemis We explored several directions without the overlay but ultimately decided that it makes the cloud more recognizable as such. |
|
As I said, I still feel like the overlay strokes make them not fit into the set. I don't dislike the left one without strokes so much. I kind of recall the one I didn't like was more symmetric? We can discuss it again at the Sync next Tuesday. |
Juliusschaeper
force-pushed
the
cloud-icons
branch
from
3247f22
to
b15c9f0
Compare
|
Updated cloud shape to a single outline |
There was a problem hiding this comment.
@Juliusschaeper something funky is happening with the SVGs and they're appearing only as solid black square when I view the files. @colebemis can you help?
|
@Juliusschaeper Does your icon frame have a background in Figma when you're exporting it? That could be the reason you see the black squares @ashygee |
Juliusschaeper
force-pushed
the
cloud-icons
branch
from
ee2310b
to
6f33cb6
Compare
|
The |
|
@colebemis @ashygee @edokoa I’m not sure why we haven’t considered this, but I do like how it makes it more consistent and readable. Thoughts?
|
|
I agree with the slash. Watching it in mobile it seems that the slash is optically misaligned to the right (at 16px). |
Juliusschaeper
force-pushed
the
cloud-icons
branch
from
f0dc854
to
d2aac38
Compare
|
Pushed an update with improved optical alignment of the |
icons/cloud-24.svg
Outdated
| @@ -0,0 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"><path d="M0 0h24v24H0z"/><path fill-rule="evenodd" d="M3.103 10.107c0-4.244 3.445-7.607 7.733-7.607 3.19 0 5.912 1.858 7.099 4.563a.634.634 0 01.01.022l.001.006C21.348 7.345 24 10.095 24 13.536 24 17.148 21.076 20 17.431 20H5.017C2.23 20 0 17.83 0 15.06a4.9 4.9 0 013.112-4.581 8.024 8.024 0 01-.009-.372zM10.836 4c-3.485 0-6.233 2.717-6.233 6.107 0 .284.022.602.052.756a.75.75 0 01-.552.869c-1.52.385-2.603 1.712-2.603 3.328 0 1.917 1.532 3.44 3.517 3.44h12.414c2.843 0 5.069-2.206 5.069-4.964 0-2.759-2.226-4.965-5.069-4.965a.75.75 0 01-.696-.47l-.179-.446C15.606 5.5 13.424 4 10.836 4z"/></svg> | |||
Juliusschaeper
force-pushed
the
cloud-icons
branch
from
91127ca
to
2abc48e
Compare
Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Added
cloudandcloud-offlineicons based on this request https://github.com/github/primer/issues/411