Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh issue icons #614

Merged
merged 3 commits into from
May 14, 2021
Merged

Refresh issue icons #614

merged 3 commits into from
May 14, 2021

Conversation

ashygee
Copy link
Contributor

@ashygee ashygee commented May 13, 2021

This adds refreshed issue icons

image

@ashygee ashygee changed the base branch from main to release-14.0.0 May 13, 2021 20:48
@colebemis colebemis merged commit 2d7c66f into release-14.0.0 May 14, 2021
@colebemis colebemis deleted the refresh-issue-icons branch May 14, 2021 03:15
@laserlemon
Copy link

Out of curiosity, where did issue-in-progress go? We have a use case for it in our app. And issue-reopened seems to have been left out of the conversion from exclamations to dots. Was that intentional?

@Andre601
Copy link

Andre601 commented May 15, 2021

I need to ask this: Why was issue-closed accepted? Will that be used on GitHub in the near future?
If so, why did it not receive some minor changes?

Right now is the issue-closed icon identical to the check-circle one.

I made this comparison here between the issue-closed and check-circle icons, by importing the 24px version of each at 500px scale into Gimp (So both are 500x500px dimension)

comparison

The left one is the check-circle and the right one the issue-closed icon and as you can see is there virtually no difference between both.

This is imo wasted storage space, since the check-circle could've just been used for closed issues imo.
Alternatively could the old issue icon be just updated with the dot to make it more unique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants