Use more explicit dependencies for Rails helper #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't require all of Rails, only ActionView & Railties. Reduce the dependencies here means that it enables folks to use only parts of Rails and to slim down their applications by removing unused components of Rails.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/octicons/HfCmCV3PF9PAPY6r5Bq6VGL5VqSs |
joelhawksley
approved these changes
Mar 24, 2021
|
@joelhawksley Looks like CI didn't run for some required builds, do they need to be explicitly triggered? |
|
@dbussink I'm not sure. @colebemis mind having a look here? |
@colebemis Any idea what is up here and if we can get this merged? |
This was referenced Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't require all of Rails, only ActionView & Railties. Reducing the dependencies here means that it enables folks to use only parts of Rails and to slim down their applications by removing unused components of Rails.