Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[octicons-react] Add className to the type definition #271

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

pocke
Copy link
Contributor

@pocke pocke commented Jan 3, 2019

Problem

octicons-react's Octicon component receives className as a prop, but the type definition does not include className prop.

export default function Octicon(props) {
const {ariaLabel, children, className, height, icon: Icon, size, verticalAlign, width} = props

Solution

Add className to the type definition.

@jonrohan
Copy link
Member

jonrohan commented Jan 8, 2019

Thanks for the PR. I'm gonna let @shawnbot take a look at this one.

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The OcticonsProps interface now accurately reflects the props accepted by the Octicon component 👍 Thanks, @pocke 🎉

Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@pocke
Copy link
Contributor Author

pocke commented Jun 18, 2019

Thank you for reviewing!
Should I do anything for this pull request?

@shawnbot
Copy link
Contributor

@pocke nope! @jonrohan, let's include this in the next patch release.

@felixfbecker
Copy link

Is this blocked by anything?

@jonrohan jonrohan changed the base branch from master to release-9.2.0 October 14, 2019 23:01
@jonrohan jonrohan mentioned this pull request Oct 14, 2019
4 tasks
@jonrohan jonrohan merged commit 006ec94 into primer:release-9.2.0 Oct 14, 2019
@pocke pocke deleted the classname branch October 15, 2019 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants