Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contrib Doc Updates #256

Merged
merged 5 commits into from
Jan 8, 2019
Merged

Contrib Doc Updates #256

merged 5 commits into from
Jan 8, 2019

Conversation

emilybrick
Copy link
Contributor

@emilybrick emilybrick commented Nov 9, 2018 •
edited
Loading

Updated contributing docs as per changes to the workflow

making sure to add

  • components need to have keywords in the Figma file
  • need to make sure that the SVG has a single path
  • no longer need to publish the copy Octicons icon, can just drag it into the master file (if you're a maintainer)

@emilybrick
Contrib Doc Updates
5290257 
Updated contributing docs as per changes to the workflow
shawnbot
shawnbot approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@jonrohan jonrohan changed the base branch from master to release-8.3.0 January 8, 2019 22:37
@jonrohan jonrohan mentioned this pull request Jan 8, 2019
Merged
@jonrohan jonrohan merged commit 84b9714 into release-8.3.0 Jan 8, 2019
@jonrohan jonrohan deleted the octicons-contributing-updates branch January 8, 2019 22:42
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilybrick @shawnbot @jonrohan