Stop checking the build directory into the repo #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick heads up that the readme needs to be updated for this. Just stumbled over this looking for
|
|
Thanks for the ping, I have an update to the readme ready in this PR #120 but I'm going to update it to make sure that I clearly say the |
dmitshur
added a commit
to shurcooL/octicon
that referenced
this pull request
Sep 17, 2016
The build/svg.json file has been removed upstream as of primer/octicons#118.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull updates the
.gitignoreand.npmignoreso that the/build/directory is not checked into the repository, but it's included in the package published to npm.The advantages to doing this are
/svg/folders confusing users/build/files often creates conflicts