Skip to content

Update mark-github-24 sizing #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Conversation

durfee
Copy link
Contributor

@durfee durfee commented Dec 11, 2024

This PR fixes a sizing issue of the GitHub mark (see below)

Screenshot 2024-11-28 at 10 04 38

Here's a before/after

image

Old is in purple, new is in grey.

@durfee durfee requested a review from a team as a code owner December 11, 2024 20:06
@durfee durfee requested a review from CameronFoxly December 11, 2024 20:06
Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: b7439a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@durfee
Copy link
Contributor Author

durfee commented Dec 11, 2024

Following up with the branch feedback in Figma

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait sorry, why is the markdown icon being deleted?

@durfee
Copy link
Contributor Author

durfee commented Dec 16, 2024

Oh goodness my bad, I copy pasted over the wrong one 🙈 Uploading the correct change in a moment

@durfee durfee requested a review from camertron December 16, 2024 20:31
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 14, 2025
Copy link
Contributor

@CameronFoxly CameronFoxly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonrohan jonrohan merged commit cdb17c3 into primer:main Feb 18, 2025
10 of 11 checks passed
@primer primer bot mentioned this pull request Feb 18, 2025
@TylerJDev TylerJDev mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants