Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(octicons-styled): update how package is output to reduce bundle size #1027

Merged
merged 6 commits into from
Oct 30, 2024
Merged

fix(octicons-styled): update how package is output to reduce bundle size #1027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a4cb9bc
fix(octicons-styled): update how package is output to reduce bundle size
joshblack Jun 25, 2024
a7c3d36
chore: add changeset
joshblack Jun 25, 2024
7b55477
Merge branch 'main' into chore/update-rollup-to-latest
joshblack Sep 3, 2024
dabf3b4
Merge branch 'main' into chore/update-rollup-to-latest
camertron Sep 18, 2024
91619db
chore: update rollup config
joshblack Oct 29, 2024
5b7a094
Merge branch 'main' into chore/update-rollup-to-latest
joshblack Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/six-buttons-listen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/octicons': minor
---

Update the build output to reduce number of generated assets included in the package on npm
13 changes: 6 additions & 7 deletions lib/octicons_styled/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"test": "jest",
"posttest": "npm run ts-test",
"lint": "eslint src script",
"rollup": "rollup -c"
"rollup": "rollup -c --bundleConfigAsCjs"
},
"keywords": [
"GitHub",
Expand All @@ -41,13 +41,14 @@
"styled-components": "4.x || 5.x"
},
"devDependencies": {
"@babel/core": "7.24.7",
"@babel/preset-env": "7.24.7",
"@babel/preset-react": "7.24.7",
"@github/prettier-config": "0.0.4",
"@rollup/plugin-babel": "6.0.4",
"@testing-library/jest-dom": "^5.3.0",
"@testing-library/react": "^10.0.2",
"@types/react": "^16.4.6",
"babel-preset-env": "^1.7.0",
"babel-preset-react": "^6.24.1",
"babel-preset-stage-0": "^6.24.1",
"eslint": "^6.5.1",
"eslint-plugin-github": "4.1.3",
"eslint-plugin-jest": "^21.17.0",
Expand All @@ -59,9 +60,7 @@
"next": "^11.1.0",
"react": "^16.4.0",
"react-dom": "^16.4.1",
"rollup": "^0.62.0",
"rollup-plugin-babel": "^3.0.5",
"rollup-plugin-commonjs": "^9.1.3",
"rollup": "^4.18.0",
"styled-components": "^5.1.0",
"typescript": "^3.7.5"
},
Expand Down
31 changes: 11 additions & 20 deletions lib/octicons_styled/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import babel from 'rollup-plugin-babel'
import commonjs from 'rollup-plugin-commonjs'
import babel from '@rollup/plugin-babel'
// eslint-disable-next-line import/no-namespace
import * as octicons from '../octicons_react/dist/index.esm'

Expand All @@ -11,36 +10,28 @@ export default [
plugins: [
babel({
babelrc: false,
presets: [
[require.resolve('babel-preset-env'), {modules: false}],
require.resolve('babel-preset-stage-0'),
require.resolve('babel-preset-react')
]
}),
commonjs()
presets: [[require.resolve('@babel/preset-env'), {modules: false}], require.resolve('@babel/preset-react')],
babelHelpers: 'inline'
})
],
output: {
file: 'dist/index.umd.js',
format: 'umd',
name: 'reocticons'
}
},
...icons.map(name => ({
input: `src/__generated__/icons/${name}.js`,
{
input: Object.fromEntries(icons.map(name => [`icons/${name}`, `src/__generated__/icons/${name}.js`])),
plugins: [
babel({
babelrc: false,
presets: [
[require.resolve('babel-preset-env'), {modules: false}],
require.resolve('babel-preset-stage-0'),
require.resolve('babel-preset-react')
]
}),
commonjs()
presets: [[require.resolve('@babel/preset-env'), {modules: false}], require.resolve('@babel/preset-react')],
babelHelpers: 'bundled'
})
],
output: {
file: `dist/icons/${name}.js`,
dir: 'dist',
format: 'esm'
}
}))
}
]
Loading
Loading