Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon Request] Empty Checkbox #942

Closed
yardenshoham opened this issue Apr 30, 2023 · 3 comments
Closed

[Icon Request] Empty Checkbox #942

yardenshoham opened this issue Apr 30, 2023 · 3 comments
Labels
octicon type: feedback

Comments

@yardenshoham
Copy link

yardenshoham commented Apr 30, 2023 •
edited
Loading

To show a button for adding an empty checkbox I'd like an icon exactly like https://primer.style/design/foundations/icons/checkbox-16 but without the checkmark. That way I'd have an SVG for both an empty checkbox and a checked checkbox.

How about:

<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16"><path d="M2.75 1h10.5c.966 0 1.75.784 1.75 1.75v10.5A1.75 1.75 0 0 1 13.25 15H2.75A1.75 1.75 0 0 1 1 13.25V2.75C1 1.784 1.784 1 2.75 1ZM2.5 2.75v10.5c0 .138.112.25.25.25h10.5a.25.25 0 0 0 .25-.25V2.75a.25.25 0 0 0-.25-.25H2.75a.25.25 0 0 0-.25.25Z"/></svg>
@yardenshoham yardenshoham mentioned this issue Apr 30, 2023
Merged
silverwind pushed a commit to go-gitea/gitea that referenced this issue Apr 30, 2023
@yardenshoham
Remove all direct references to font-awesome (#24448)
9799159 
- Related #10410
- I had to add an SVG for an empty checkbox
primer/octicons#942

# Before

![image](https://user-images.githubusercontent.com/20454870/235374683-13f355c3-1245-40db-adda-4c710fc80288.png)

# After

![image](https://user-images.githubusercontent.com/20454870/235374655-cc637132-f314-424d-9243-13d45b8915d5.png)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@tallys
Copy link
Contributor

tallys commented May 1, 2023

Hi, thanks for opening the issue. We already have a Square Icon in Octicons.

@yardenshoham
Copy link
Author

Next to the checkbox, it looks like they have different sizes

@tallys
Copy link
Contributor

tallys commented May 2, 2023

Hi @yardenshoham, we intentionally do not have an empty toggle checkbox. Additionally, including it could potentially encourage inaccessible checkboxes in being built in the UI. If you need a checkbox, check out https://primer.style/react/Checkbox.

@tallys tallys closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
octicon type: feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tallys @yardenshoham