Skip to content

Commit

Permalink
Merge branch 'master' into js-edits
Browse files Browse the repository at this point in the history
  • Loading branch information
ashygee authored Sep 28, 2020
2 parents e4f2fb0 + 7567fc7 commit b747825
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/content/packages/jekyll.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ source: 'https://github.com/primer/octicons/tree/master/lib/octicons_jekyll'
[![Gem version](https://img.shields.io/gem/v/jekyll-octicons.svg)](https://rubygems.org/gems/jekyll-octicons)


This jekyll liquid tag is a plugin that will let you easily include svg octicons in your jekyll sites.
The Jekyll liquid tag is a plugin that lets you include octicons in your Jekyll sites.

## Install

Expand Down
4 changes: 2 additions & 2 deletions docs/content/packages/rails.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ source: 'https://github.com/primer/octicons/tree/master/lib/octicons_helper'

[![Gem version](https://img.shields.io/gem/v/octicons_helper.svg)](https://rubygems.org/gems/octicons_helper)

This rails helper lets you easily include svg octicons in your rails apps.
The Rails helper lets you include octicons in your Rails apps.

## Install

Expand All @@ -26,4 +26,4 @@ We recommend including the CSS in the [`@primer/octicons`](/packages/javascript)

## Caching

`octicons_helper` caches repeated calls to `octicon` based on the name of the icon and the provided `options` hash. Avoid arbitrary/high cardinality `options` (such as an `id` with a unique record identifier), as they can cause a memory leak.
`octicons_helper` caches repeated calls to `octicon` based on the name of the icon and the provided `options` hash. Avoid arbitrary/high cardinality `options` (such as an `id` with a unique record identifier), as they can cause a memory leak.

0 comments on commit b747825

Please sign in to comment.