Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rules): update no-system-props to include Blankslate #76

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

joshblack
Copy link
Member

The Blankslate component currently supports a border prop that is not considered a system prop. This PR adds Blankslate to the list of excluded component props for this rule.

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

🦋 Changeset detected

Latest commit: 5ea6a27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshblack joshblack merged commit 1750256 into main Aug 15, 2023
4 checks passed
@joshblack joshblack deleted the joshblack-patch-1 branch August 15, 2023 14:41
@primer-css primer-css mentioned this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants