Define some component mappings for jsx-a11y #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f03cd7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines the component mapping for
eslint-plugin-jsx-a11yplugin to get more linting coverage. We can define more mappings as we see fit but I think it's fine to start small for now since this feature is pretty new ineslint-plugin-jsx-a11y.These PRC button components are simple and don't support
asprop so we are able to use the 1:1 component mapping feature ineslint-plugin-jsx-a11y.plugin:github/reactpulls ineslint-plugin-jsx-a11y.We discussed previously that it makes sense for
primer-react/recommendedto have these mappings defined so PRC consumers don't need to define their own.