Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the docsId field to group multiple versions of a React component #751

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

camertron
Copy link
Contributor

This PR allows a docsId field to group multiple versions of a React component together into a single page. The docsId concept is motivated by the need to generate a single page for the Tooltip component, which has two versions named tooltip and tooltip_v2.

@camertron camertron requested a review from a team as a code owner April 3, 2024 22:40
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@camertron
Copy link
Contributor Author

Note that the checks for this PR won't pass until primer/react#4458 is merged and released.

@camertron camertron merged commit 5a658ac into main Apr 8, 2024
4 checks passed
@camertron camertron deleted the docs_id branch April 8, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants