Skip to content

Toggle switch component guidelines #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 30, 2022
Merged

Toggle switch component guidelines #249

merged 12 commits into from
Mar 30, 2022

Conversation

mperrotti
Copy link
Contributor

No description provided.

@mperrotti mperrotti requested a review from a team as a code owner March 22, 2022 23:52
@vercel
Copy link

vercel bot commented Mar 22, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/design/6UMDSHrdVjKA65j5MKNqQjGW5xdr
✅ Preview: https://design-git-mp-toggle-switch-guidelines-primer.vercel.app

@mperrotti mperrotti mentioned this pull request Mar 23, 2022
Merged
6 tasks
yaili
yaili requested changes Mar 23, 2022
View reviewed changes
Copy link
Member

@yaili yaili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments, you also need to add the component to this page 😄

@mperrotti @yaili
Update content/ui-patterns/saving.mdx
47427ac 
Co-authored-by: Inayaili León <yaili@github.com>
@mperrotti @yaili
Update content/components/toggle-switch.mdx
abd2986 
Co-authored-by: Inayaili León <yaili@github.com>
mperrotti and others added 5 commits March 23, 2022 11:49
@mperrotti @yaili
Update content/components/toggle-switch.mdx
b5c66ce 
Co-authored-by: Inayaili León <yaili@github.com>
@mperrotti @yaili
Update content/components/toggle-switch.mdx
ee046ea 
Co-authored-by: Inayaili León <yaili@github.com>
@mperrotti @yaili
Update content/components/toggle-switch.mdx
981fad5 
Co-authored-by: Inayaili León <yaili@github.com>
@mperrotti @yaili
Update content/components/toggle-switch.mdx
55c76db 
Co-authored-by: Inayaili León <yaili@github.com>
@mperrotti @yaili
Update content/components/toggle-switch.mdx
ed32686 
Co-authored-by: Inayaili León <yaili@github.com>
@mperrotti mperrotti requested a review from yaili March 24, 2022 14:58
yaili
yaili approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@yaili yaili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

ichelsea
ichelsea reviewed Mar 28, 2022
View reviewed changes
Copy link
Contributor

@ichelsea ichelsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple suggestions 🙂

@mperrotti mperrotti merged commit 9b6e624 into main Mar 30, 2022
@mperrotti mperrotti deleted the mp/toggle-switch-guidelines branch March 30, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichelsea ichelsea ichelsea left review comments

@yaili yaili yaili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mperrotti @yaili @ichelsea