This repository was archived by the owner on Mar 31, 2020. It is now read-only.
Add --retries and --verify options #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbot
added a commit
to primer/react
that referenced
this pull request
Mar 15, 2019
This is a test of the retry functionality in primer/deploy#12
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempted fix for #6 and a more certain fix for #9. There are two new options:
--retries/-r(oroptions.retries) is a number that defaults to 3, and determines the number of times that we'll re-try the initial deployment. There are tests that simulate failure a number of times, and they seem to work, so let's give this a shot?--verify(oroptions.verify) is the inverse of the Now CLI's--no-verifyflag. We default to false because verification can time out for sites that scale (as described in Run now with--no-verify#9), and there's no way to adjust the timeout period. Closes Run now with--no-verify#9.In other words:
now --no-verifyis the default, and passing--verifywill runnow.This also includes a fix for #10, because why not?