Create a new CSS @layer
for octicons
#2841
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When styles downstream in Primer React interact with an icon, and
.octicon
is present on the page, the.octicon
call will take precedence since it is in the anonymous layer and Primer React styles are brought in through theprimer-react
layer.This change updates the
.octicon
class to be wrapped in a@layer
namedprimer.icons
. We should make sure this layer appears first to avoid any overrides in the future.