Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new
styleContaineroption in primevue config to be able to pass via configuration where the style tags need to be injected, allowing to pass the shadowRoot in the defineCustomElement setup function and keeping the existing functionality without breaking changes.Example use:
This is a much simpler proposal than #7351 that will also help with #4001 that will add support for custom elements to the library without breaking changes.
Components that use the Portal like the dialog will be rendered by default in the body and the styles will be added to the shadowRoot, consumers will have to handle this situation in their custom elements, by either coping the styles to the document head or by passing a template ref as anchorEl to render this components inside the shadowRoot.
Example
This fix was tested locally, and the styles are correctly copied to the shadowRoot, when building a "regular" vue app or a custom element without a shadow dom, the styles are injected to the document head and everything works as usual