Skip to content

Invalid "sortField" property type in Vue and type definition files #681

Closed
@nestorrente

Description

@nestorrente

This issue is related to #647. In that issue, @richardmward pointed that sortField prop of DataTable component was declared as String in the .vue file - that was fixed in version 3.0.2. However, the same issue is present in TableHeader and Column components. Also, Column.d.ts file has sortField defined as string, instead of string | Function.

The same issue is also present in DataTable, TableHeader and Column components of version 2.x - also in their corresponding type declaration files.

Refering to TypeScript definition files, it might be better to define it as string | ((item: any) => any), in order to give a little more information about function's signature.

Thank you very much for your time.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type: BugIssue contains a bug related to a specific component. Something about the component is not working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions