Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings #41

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Remove warnings #41

merged 5 commits into from
Jan 24, 2024

Conversation

VitorTrin
Copy link
Contributor

Removes a compilation warning for using both applications and extra_applications on mix.exs and
removes a warning that would happen both in tests and production about using negative stepped ranges as a parameter for String.slice

@VitorTrin VitorTrin requested a review from a team as a code owner January 24, 2024 14:49
MaeIsBad
MaeIsBad previously approved these changes Jan 24, 2024
Copy link
Member

@MaeIsBad MaeIsBad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped elixir version to 1.16, since this warning doesn't occur below, and bumped the package version to 1.1.1

This reverts commit b5e0b30.
Dialyzer doesn't have the types for the legacy File.stream!/3 function
and we don't want to break backwards compatibility for now
@MaeIsBad MaeIsBad merged commit 325db9a into primait:master Jan 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants