This repository was archived by the owner on Sep 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for adding plv8. Unfortunately this broke the aws_s3 extension and I have to no idea why. I have no idea on how to install it and haven't found any docs on that :-/
|
6a03441
to
e9e3688
Compare
plv8 downloads and builds a version of v8. the system compiler, g++, is too old for that, and runs into an internal compile error. by explicitly using clang++ to build v8, we circumvent this problem. the rest of plv8 is then built with the same compiler that was used for postgres, which is probably important. but that works, so we only switch the compiler for building v8.
Just fyi, cmake also has binary versions available at: https://cmake.org/download/ Then we don't have to build it from source. But I guess this just has to be built once, and we'll soon switch away from it anyways, so nvm :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.