Skip to content
This repository was archived by the owner on Sep 22, 2023. It is now read-only.

add plv8 #7

Merged
merged 23 commits into from
Aug 30, 2023
Merged

add plv8 #7

merged 23 commits into from
Aug 30, 2023

Conversation

fdietze
Copy link
Contributor

@fdietze fdietze commented Aug 17, 2023

No description provided.

@FloWi
Copy link
Contributor

FloWi commented Aug 17, 2023

Thanks for adding plv8. Unfortunately this broke the aws_s3 extension and I have to no idea why. I have no idea on how to install it and haven't found any docs on that :-/

Applying migration `20220228201822_initial_migration`
Error: P3018

A migration failed to apply. New migrations cannot be applied before the error is recovered from. Read more about how to resolve migration issues in a production database: https://pris.ly/d/migrate-resolve

Migration name: 20220228201822_initial_migration

Database error code: 58P01

Database error:
ERROR: could not open extension control file "/usr/share/postgresql/14/extension/aws_s3.control": No such file or directory

DbError { severity: "ERROR", parsed_severity: Some(Error), code: SqlState(E58P01), message: "could not open extension control file \"/usr/share/postgresql/14/extension/aws_s3.control\": No such file or directory", detail: None, hint: None, position: None, where_: None, schema: None, table: None, column: None, datatype: None, constraint: None, file: Some("extension.c"), line: Some(535), routine: Some("parse_extension_control_file") }

@fdietze fdietze force-pushed the fdietze-2023-08-17-add-plv8 branch from 6a03441 to e9e3688 Compare August 29, 2023 12:54
futile and others added 6 commits August 29, 2023 17:21
plv8 downloads and builds a version of v8. the system compiler, g++, is
too old for that, and runs into an internal compile error. by explicitly using
clang++ to build v8, we circumvent this problem.

the rest of plv8 is then built with the same compiler that was used for
postgres, which is probably important. but that works, so we only switch
the compiler for building v8.
@krux02 krux02 marked this pull request as ready for review August 30, 2023 07:51
@krux02 krux02 marked this pull request as draft August 30, 2023 07:51
@futile
Copy link
Contributor

futile commented Aug 30, 2023

Just fyi, cmake also has binary versions available at: https://cmake.org/download/

Then we don't have to build it from source. But I guess this just has to be built once, and we'll soon switch away from it anyways, so nvm :)

@futile futile marked this pull request as ready for review August 30, 2023 14:24
@krux02 krux02 merged commit d4ecfe3 into main Aug 30, 2023
@krux02 krux02 deleted the fdietze-2023-08-17-add-plv8 branch August 30, 2023 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants