Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”§ chore : yml을 톡해 μ‹œνλ¦¬ν‹° μ„€μ • 정보 관리 #143

Merged
merged 2 commits into from
Aug 7, 2022
Merged

πŸ”§ chore : yml을 톡해 μ‹œνλ¦¬ν‹° μ„€μ • 정보 관리 #143

merged 2 commits into from
Aug 7, 2022

Conversation

kimziou77
Copy link
Member

@kimziou77 kimziou77 commented Aug 7, 2022 •
edited
Loading

μž‘μ—…μ‚¬ν•­

기쑴에 μ½”λ“œλ₯Ό μˆ˜μ •ν•΄μ•Ό λ³€κ²½ν•  수 μžˆμ—ˆλ˜ μ‹œνλ¦¬ν‹° μžμ› μ„€μ • 뢀뢄을 yml λ³€κ²½λ§Œμ„ 톡해 λ³€κ²½ν•  수 μžˆλ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

  • ν—ˆμš©ν•˜λŠ” origin은 cors.allowed.origin에 μž‘μ„±ν•©λ‹ˆλ‹€
    image

  • ν•„ν„°λ₯Ό λ¬΄μ‹œν•˜λŠ” λ¦¬μ†ŒμŠ€λŠ” security.patterns.ignoring 에 μž‘μ„±ν•©λ‹ˆλ‹€
    image

  • 둜그인이 ν•„μš”μ—†λŠ” μš”μ²­μ€ security.patterns.permit-all 에 μž‘μ„±ν•©λ‹ˆλ‹€
    image

μ€‘μ μ μœΌλ‘œ 봐야할 λΆ€λΆ„

μŠ€μ›¨κ±° 토큰 μž…λ ₯μ‹œ 정상 μž‘λ™ν•©λ‹ˆλ‹€

λ³€κ²½λœ 뢀뢄은 λ‹€μŒκ³Ό κ°™μŠ΅λ‹ˆλ‹€

  • cors.origin에 우리 도메인 μΆ”κ°€

image

@kimziou77 kimziou77 added the πŸ”§ chore λΉŒλ“œμ—…λ¬΄ μˆ˜μ •, νŒ¨ν‚€μ§€ λ§€λ‹ˆμ € μˆ˜μ • label Aug 7, 2022
@kimziou77 kimziou77 requested a review from zxcv9203 as a code owner August 7, 2022 13:10
@kimziou77 kimziou77 self-assigned this Aug 7, 2022
@kimziou77 kimziou77 requested a review from ynoolee as a code owner August 7, 2022 13:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2022 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

zxcv9203
zxcv9203 approved these changes Aug 7, 2022
View reviewed changes
Copy link
Collaborator

@zxcv9203 zxcv9203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

403을 ν•΄κ²°ν•˜μ‹œλ‹€λ‹ˆ.. κ·Έμ € λΉ› 😲 πŸ₯³πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³

@kimziou77 kimziou77 merged commit b86da50 into develop Aug 7, 2022
@kimziou77 kimziou77 deleted the chore/142-μ‹œνλ¦¬ν‹°-리뉴얼 branch August 7, 2022 13:42
@kimziou77 kimziou77 restored the chore/142-μ‹œνλ¦¬ν‹°-리뉴얼 branch August 7, 2022 14:00
@kimziou77 kimziou77 mentioned this pull request Aug 7, 2022
Merged
@SeokRae
Copy link

SeokRae commented Aug 7, 2022 •
edited
Loading

원인이 λ¬΄μ—‡μ΄μ—ˆλ‚˜μš”!!

@kimziou77
Copy link
Member Author

kimziou77 commented Aug 8, 2022 •
edited
Loading

@SeokRae λ‘œμ»¬μ—μ„œ ν–ˆμ„λ•ŒλŠ” μŠ€μ›¨κ±°μ—μ„œ μš”μ²­μ„ λ³΄λƒˆμ„ λ•Œ λ‹€μ΄λ ‰νŠΈλ‘œ λ°›μ•„μ˜¬ 수 μžˆμ—ˆλŠ”λ°,
dev.checkmoi.ga μ„œλ²„λŠ” nginxλ₯Ό κ±°μ³μ„œ μ™€μ„œ cors λ¬Έμ œκ°€ λ‚œ λ“― ν•©λ‹ˆλ‹€!?
dev.checkmoi.gaλ₯Ό origin으둜 μ„€μ •ν•΄μ£Όμ–΄μ„œ ν•΄κ²°λœ 것 κ°™μŠ΅λ‹ˆλ‹€ 😺 !!!

@SeokRae
Copy link

SeokRae commented Aug 8, 2022 •
edited
Loading

@SeokRae λ‘œμ»¬μ—μ„œ ν–ˆμ„λ•ŒλŠ” μŠ€μ›¨κ±°μ—μ„œ μš”μ²­μ„ λ³΄λƒˆμ„ λ•Œ λ‹€μ΄λ ‰νŠΈλ‘œ λ°›μ•„μ˜¬ 수 μžˆμ—ˆλŠ”λ°,
dev.checkmoi.ga μ„œλ²„λŠ” 쀑간에 nginx ν”„λ‘μ‹œλ₯Ό κ±°μ³μ„œ μ™€μ„œ cors λ¬Έμ œκ°€ λ‚œ λ“― ν•©λ‹ˆλ‹€!?
dev.checkmoi.gaλ₯Ό origin으둜 μ„€μ •ν•΄μ£Όμ–΄μ„œ ν•΄κ²°λœ 것 κ°™μŠ΅λ‹ˆλ‹€ 😺 !!!

@kimziou77
μ•„λž˜μ™€ 같은 λ‚΄μš©μ΄μ—ˆκ² κ΅°μš” !?

swagger-api/swagger-ui#5104

@kimziou77
Copy link
Member Author

@SeokRae ν˜Ήμ‹œ μ•„λž˜ λ‚΄μš©μ΄ μ–΄λ–€κ±΄κ°€μš”??!

@SeokRae
Copy link

SeokRae commented Aug 8, 2022 •
edited
Loading

@SeokRae ν˜Ήμ‹œ μ•„λž˜ λ‚΄μš©μ΄ μ–΄λ–€κ±΄κ°€μš”??!

@kimziou77
링크 볡사가 잘λͺ»λ˜μ—ˆλ„€μš” .!!
링크 μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

λ‚΄μš©μ„ λ³΄λ‹ˆ swagger api document 생성 μ‹œ oauth2 인증을 μΆ”κ°€ν•  λ•Œ λ¦¬λ‹€μ΄λ ‰μ…˜ μ‹œ μ‹€νŒ¨κ°€ λ°œμƒλ˜λŠ” 원인을 ν•΄κ²°ν•˜λŠ” λ‚΄μš© κ°™μŠ΅λ‹ˆλ‹€.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxcv9203 zxcv9203 zxcv9203 approved these changes

@ynoolee ynoolee Awaiting requested review from ynoolee

Assignees

@kimziou77 kimziou77

Labels
πŸ”§ chore λΉŒλ“œμ—…λ¬΄ μˆ˜μ •, νŒ¨ν‚€μ§€ λ§€λ‹ˆμ € μˆ˜μ •
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

μ‹œνλ¦¬ν‹° 리뉴얼
3 participants
@kimziou77 @SeokRae @zxcv9203