-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PropsWithChildren to Function Component prop interfaces in the core package #431
Conversation
✅ Deploy Preview for craftjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 💯
@seang Do you mind updating the one in the Events component as well? So we can keep the typings in the core package consistent. I guess since the component has no other props, then we would have to do type EventsProps = {
children?: React.ReactNode;
} |
@prevwong sure thing! added |
Co-authored-by: Prev Wong <prevwong@gmail.com>
Addresses #430