Simplify CI setup #320
Merged
Simplify CI setup #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipis
requested changes
Aug 19, 2020
|
Looks like there's still two "Test in Chrome locally" sections. Probably best to either combine the commands into one section like you did (though maybe add CI stuff looks good! I think the scripts are much more streamlined now. |
|
@chrissantamaria Thanks! Fixed. |
|
This should be ready for a re-review. |
nickserv
requested changes
Aug 25, 2020
kaicataldo
force-pushed
the
simplify-ci
branch
from
f5b2ba7 to
aac24bc
Compare
|
Would love to land this since it's just an internal chore. Please re-review! |
nickserv
approved these changes
Aug 29, 2020
sibiraj-s
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a lot of indirection in our dev/Ci setup (built up over time). This PR aims to split tasks into easier to understand groupings, separate concerns, and make our scripts more self-explanatory/explicit. I also split out linting from formatting, because, after nearly 5 years of working on linters, I think formatting should be a separate concern.