Handle else blocks and comments in unbuffered code #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Shinigami92
added
the
type: enhancement
Shinigami92
approved these changes
Aug 12, 2025
Member
|
As usual, release hopefully in the evening, because I wont like to release from my company laptop 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #601, I missed a couple critical cases:
elseandelse ifstatements, where the syntax error is actually at the start of the line, not the endif (foo) // here, we're doing xyz), since adding an empty block at the end would mean it'd be commented out if it's a//comment@Shinigami92 hope you don't mind that I went straight for a PR instead of opening an issue first.