Add third option for pugClassNotation and pugIdNotation

[Shinigami92]

This will be a follow-up of #36, because this third option will need a bit more refactoring and is not quite as easy to implement as the other two options.
To let users already benefit from the other two options, we will create a release before starting working on this third option.

[homerjam]

This will be extremely helpful when using Tailwind!

Has this been started? Are there any pointers available for where to begin?

[Shinigami92]

It's kinda easy to start by adding the new option to the choices:

plugin-pug/src/options/pug-class-notation.ts

Lines 11 to 14 in a66432d

	choices: [
	{ value: 'literal', description: 'Forces all valid classes to be printed as literals.' },
	{ value: 'as-is', description: 'Disables class formatting.' }
	]

plugin-pug/src/options/pug-id-notation.ts

Lines 11 to 14 in a66432d

	choices: [
	{ value: 'literal', description: 'Forces all valid ids to be printed as literals.' },
	{ value: 'as-is', description: 'Disables id formatting.' }
	]

And then add tests for the option in

• https://github.com/prettier/plugin-pug/tree/main/tests/options/pugClassNotation
• https://github.com/prettier/plugin-pug/tree/main/tests/options/pugIdNotation

From there you can then just try-and-error through the code with test-driven-development ^^

Just use yarn test tests/options/pugClassNotation and yarn test tests/options/pugIdNotation

[Shinigami92]

@h0merjam The third choice should be attribute (opposite of literal ^^)

And then your both function friends are here and below: https://github.com/prettier/plugin-pug/blob/main/src/printer.ts#L577

start-attributes and attribute

[homerjam]

Hmm, this isn't quite as simple as I'd hoped!

I've tried to grasp what's happening with the literal option and how the attribute option might work. Based on what I think I understand so far the steps might be:

• store literals via class/id token type processor (this would require adding new private vars to the PugPrinter class❓ - classesToAppend / idToAppend)
• convert/append literals to class/id attribute (either in existing class attribute or end-attributes / newline hooks)

Does this sound about right? 🤔

[Shinigami92]

Yes that sounds right 👍