Update to prettier 2.1, align dev support packages to latest #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_spec based on prettier/plugin-php v0.10.
…onfig-unobtrusive gets in the way of the other alignment.
|
You are welcome to open PRs for the next steps you mentioned and I'll review them when I find time. |
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns to the latest packages, based on prettier/prettier and prettier/plugin-php.
I tried to maintain as much compatibility with the existing tests and snapshots, JS code style preferences, etc as possible.
The next step would be to further align run_spec to plugin-php, update luaparse to 0.3.0 (and make the luaparser injectable), and update the snapshot tests.
With those in place, we can start fixing a few of the formatting bugs I've encountered in Roact and other open source projects.