Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stuff regarding no-tabs #55

Closed
lydell opened this issue Oct 12, 2018 · 2 comments · Fixed by #168
Closed

Update stuff regarding no-tabs #55

lydell opened this issue Oct 12, 2018 · 2 comments · Fixed by #168

Comments

@lydell
Copy link
Member

lydell commented Oct 12, 2018

ESLint 5.7 added the allowIndentationTabs option. This might turn the rule from a special rule to a validatable one.

https://eslint.org/blog/2018/10/eslint-v5.7.0-released

@lydell
Copy link
Member Author

lydell commented Oct 18, 2018

This might be a breaking change, so we should probably wait for a little while.

lydell added a commit that referenced this issue Nov 11, 2018
@lydell
Copy link
Member Author

lydell commented Jan 26, 2019

Status: Yes, this can be turned into a validatable rule. But that would require bumping the peerDependency on ESLint from >=3.14.1 to >=5.7.0. Since nobody has complained about this and there’s a note about it in the docs, I think it’s better to leave this open at least until ESLint 6 is released, or when enough people have migrated to a new enough ESLint version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant