review of printing patterns #1223
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spotted 2 patterns that further clean our printers:
printGroupAndIndentIfBreakPair
: usually we do have agroup
followed by anindentIfBreak
pointing to that same group. This involves creating aSymbol
. All of this can be put in the same logic.printIndentedGroupOrSpacedDocument
: when printing (usually the body of a loop statement) we have to choose between a[' ', body]
orgroup(indent([line, body]))
this can be simplified by just having a helper with thebody
and a condition.I also had a look at the
printPreservingEmptyLines
helper and added the logic for the comments when there are no lines. This also showed me that ourprintComments
function was ignoring empty lines between comments.Finally the
printSeparatedItem
helper has agrouped
option that should always be false if thefirstSeparator
is ahardline