Skip to content

Fixed IncludedNote.content field type #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
Merged

Fixed IncludedNote.content field type #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2edb23
Fixed IncludedNote.content field type
Ayuto Jan 31, 2025
7cebee7
Fixed formatting and tests
Ayuto Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions drafthorse/models/note.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
from .container import StringContainer
from . import BASIC, COMFORT, EXTENDED, NS_RAM
from .elements import Element
from .fields import MultiStringField, StringField
from .fields import StringField


class IncludedNote(Element):
content_code = StringField(NS_RAM, "ContentCode", required=False, profile=EXTENDED)
content: StringContainer = MultiStringField(
NS_RAM, "Content", required=False, profile=BASIC
content_code: StringField = StringField(
NS_RAM, "ContentCode", required=False, profile=EXTENDED
)
content: StringField = StringField(NS_RAM, "Content", required=False, profile=BASIC)
subject_code: StringField = StringField(
NS_RAM, "SubjectCode", required=False, profile=COMFORT
)
subject_code = StringField(NS_RAM, "SubjectCode", required=False, profile=COMFORT)

class Meta:
namespace = NS_RAM
Expand Down
4 changes: 1 addition & 3 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ def invoice_document(request):
doc.header.issue_date_time = date.today()
doc.header.languages.add("de")

note = IncludedNote()
note.content.add("Test Node 1")
doc.header.notes.add(note)
doc.header.notes.add(IncludedNote(content="Test Node 1"))

doc.trade.agreement.seller.name = "Lieferant GmbH"
doc.trade.settlement.payee.name = "Lieferant GmbH"
Expand Down