RGBDS syntax updates #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
I'm pretty unfamiliar with any new RGBDS features from the past few years. I think Danny's suggestions are going to be sufficient. Thanks! |
vulcandth
force-pushed
the
RGBDS-Syntax-Updates
branch
from
98eabe6 to
aeb42c1
Compare
dannye
reviewed
May 13, 2022
Apply dannye suggestion
vulcandth
force-pushed
the
RGBDS-Syntax-Updates
branch
from
aeb42c1 to
fe12bea
Compare
dannye
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please reference pret/pokecrystal#686 and pret/pokecrystal#905
If there is anything else that needs to be done as far as RGBDS goes, let me know.. and if I have time I can work on it.