Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gbagfx: Various fixes and improvements #330

Merged
merged 2 commits into from
Apr 25, 2020
Merged

gbagfx: Various fixes and improvements #330

merged 2 commits into from
Apr 25, 2020

Conversation

Sierraffinity
Copy link
Contributor

@Sierraffinity Sierraffinity commented Apr 22, 2020 •
edited
Loading

  • Fix num_colors exceeding amount of colors in palette leading to use of uninitialized colors
  • Handle png -> pal conversion (aka extracting JASC palettes from png)
  • Allow JASC pal files to be used as -palette argument when converting from GBA to PNG
  • Allow using only file extension as output to reuse entire path from input before extension

@Sierraffinity
gbagfx: Various fixes and improvements
8c1d0d7 
Fix num_colors exceeding amount of colors in palette leading to use of uninitialized colors
Handle png -> pal conversion (aka extracting JASC palettes from png)
Allow JASC pal files to be used as -palette argument when converting from GBA to PNG
Allow using only file extension as output to reuse entire path from input before extension
jiangzhengwenjz
jiangzhengwenjz suggested changes Apr 22, 2020
View reviewed changes
tools/gbagfx/main.c Outdated Show resolved Hide resolved
@PikalaxALT PikalaxALT merged commit 834b0dd into pret:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangzhengwenjz jiangzhengwenjz jiangzhengwenjz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sierraffinity @jiangzhengwenjz @PikalaxALT