chore(ci): Advance velox

[amitkdutta]

== NO RELEASE NOTE ==

Summary by Sourcery

Chores:

• Update the Velox submodule pointer under presto-native-execution to track the latest desired upstream commit.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the presto-native-execution Velox dependency to point to the latest upstream commit, without any code or configuration changes in this repository.

File-Level Changes

Change	Details	Files
Advance the Velox submodule reference to the latest upstream commit.	Update the Velox git reference in presto-native-execution/velox to a newer upstream commit hash No source files, build files, or configuration in this repo are modified beyond the submodule pointer	presto-native-execution/velox

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[aditi-pandit]

@amitkdutta : The build failures are legit. They need to be fixed

From "Explain error" AI

---

The failure is a linker error in the native build job, not a test assertion failure.

Root cause
velox_exec now references facebook::velox::memory::CustomMemoryResourceRegistry::global(), but the affected Presto test binaries do not link the Velox library that defines that symbol.

From the job log:

• Failing target: presto_materialized_exchange_reclaim_test
• Also fails: presto_common_test
• Error:
  • undefined reference to facebook::velox::memory::CustomMemoryResourceRegistry::global[abi:cxx11]()

This happens in the workflow build step in .github/workflows/arrow-flight-tests.yml:

• build uses cmake ... -DPRESTO_ENABLE_ARROW_FLIGHT_CONNECTOR=ON ...
• then ninja -C _build/release -j 4
• Source: https://github.com/prestodb/presto/blob/3abb789abd41333e3af44aa6788a2b4c98bc2980/.github/workflows/arrow-flight-tests.yml

Where to fix
The missing link dependencies are in these CMake targets:

1. presto-native-execution/presto_cpp/main/operators/tests/CMakeLists.txt

• presto_materialized_exchange_reclaim_test currently links only:
  • presto_operators
  • velox_exec
  • velox_memory
  • GTest::gtest
• Source: https://github.com/prestodb/presto/blob/3abb789abd41333e3af44aa6788a2b4c98bc2980/presto-native-execution/presto_cpp/main/operators/tests/CMakeLists.txt

2. presto-native-execution/presto_cpp/main/common/tests/CMakeLists.txt

• presto_common_test links several Velox libs, but not the library that now carries the custom memory resource registry symbol.
• Source: https://github.com/prestodb/presto/blob/3abb789abd41333e3af44aa6788a2b4c98bc2980/presto-native-execution/presto_cpp/main/common/tests/CMakeLists.txt

Recommended fix
Add the Velox memory allocator / memory-manager implementation library that exports CustomMemoryResourceRegistry::global() to the failing test targets’ link list.

A likely patch is:

# presto-native-execution/presto_cpp/main/operators/tests/CMakeLists.txt

target_link_libraries(
  presto_materialized_exchange_reclaim_test
  presto_operators
  velox_exec
  velox_memory
  velox_memory_manager
  GTest::gtest
)

# presto-native-execution/presto_cpp/main/common/tests/CMakeLists.txt

target_link_libraries(
  presto_common_test
  presto_common
  presto_exception
  velox_aggregates
  velox_exception
  velox_file
  velox_functions_prestosql
  velox_function_registry
  velox_presto_serializer
  velox_presto_types
  velox_window
  velox_memory_manager
  ${RE2}
  GTest::gtest
)

If velox_memory_manager is not the exact exported target name
The fix is still the same in principle: link the Velox target that provides CustomMemoryResourceRegistry::global(). In newer Velox revisions this symbol may live in a different memory-related target than velox_memory, which is why these test executables now fail to link while other binaries still succeed.

Why this is the right solution

• The failure occurs at link time, not compile time.
• The unresolved symbol originates from velox/velox/exec/libvelox_exec.a(Task.cpp.o).
• That means velox_exec was compiled successfully, but one of its transitive symbol providers is missing from the final executable link line.
• Both failing executables are small test targets with manually curated target_link_libraries(...), so they are the right place to fix it.

Secondary issue in logs
There is also a stash restore warning:

• error extracting zip archive: ... CACHEDIR.TAG: file exists

That did not stop the job; the build continued. It is not the cause of the failure.

Suggested minimal PR change
Update the two CMake test targets to include the missing Velox memory implementation target, rebuild, and rerun the arrow flight tests workflow.

[amitkdutta]

Yes its being reverted
facebookincubator/velox#17672

[aditi-pandit]

Thanks @amitkdutta

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}