feat: Add RemoveInsensitiveAggregateDistinct rule

[xin-zhang2]

Description

Add an optimizer rule to remove distinct from aggregates that are insensitive to duplicates.
Fixes #26075.

Motivation and Context

Impact

Test Plan

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.
• If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

[sourcery-ai]

Reviewer's Guide

Introduce a new optimizer rule that detects distinct aggregations on functions insensitive to duplicates and rewrites them as non-distinct, integrate it into the planner’s optimization phases, and validate its behavior with comprehensive tests.

Sequence diagram for optimizer rule application in planning phases

sequenceDiagram
    participant "PlanOptimizers"
    participant "RemoveInsensitiveAggregateDistinct"
    participant "AggregationNode"
    "PlanOptimizers"->>"RemoveInsensitiveAggregateDistinct": apply rule during optimization
    "RemoveInsensitiveAggregateDistinct"->>"AggregationNode": inspect aggregations
    "RemoveInsensitiveAggregateDistinct"->>"AggregationNode": rewrite distinct-insensitive aggregations as non-distinct
    "RemoveInsensitiveAggregateDistinct"-->>"PlanOptimizers": return updated AggregationNode

Loading

Class diagram for RemoveInsensitiveAggregateDistinct rule

classDiagram
    class RemoveInsensitiveAggregateDistinct {
        -FunctionAndTypeManager functionAndTypeManager
        +RemoveInsensitiveAggregateDistinct(FunctionAndTypeManager)
        +Pattern<AggregationNode> getPattern()
        +Result apply(AggregationNode, Captures, Context)
        -boolean hasInsensitiveDistinct(AggregationNode)
        -boolean isDistinctInsensitiveAggregation(Aggregation)
    }
    class Rule {
    }
    RemoveInsensitiveAggregateDistinct --|> Rule

Loading

Class diagram for AggregationNode and Aggregation modifications

classDiagram
    class AggregationNode {
        +Map<VariableReferenceExpression, Aggregation> getAggregations()
        +AggregationNode(...)
    }
    class Aggregation {
        +boolean isDistinct()
        +Aggregation(...)
        +FunctionHandle getFunctionHandle()
        +List<Expression> getArguments()
        +Expression getCall()
        +Expression getFilter()
        +List<SortItem> getOrderBy()
        +boolean getMask()
    }
    AggregationNode "1" o-- "*" Aggregation

Loading

File-Level Changes

Change	Details	Files
Register RemoveInsensitiveAggregateDistinct in optimizer pipeline	Add rule instantiation to the main logical optimizer rules sequence Insert rule in the redundant-removal phase of join optimizers Include rule in the stream plan optimizer rules list	presto-main-base/src/main/java/com/facebook/presto/sql/planner/PlanOptimizers.java
Implement RemoveInsensitiveAggregateDistinct rule logic	Define the set of duplicate-insensitive function names Match AggregationNode patterns for distinct aggregations on those functions Rewrite matched aggregations by clearing their distinct flag	presto-main-base/src/main/java/com/facebook/presto/sql/planner/iterative/rule/RemoveInsensitiveAggregateDistinct.java
Add tests for RemoveInsensitiveAggregateDistinct behavior	Verify rule does not fire on non-distinct, sensitive, or multi-argument aggregates Test removal of distinct on single and multiple insensitive functions Ensure mixed cases preserve distinct on sensitive functions	presto-main-base/src/test/java/com/facebook/presto/sql/planner/iterative/rule/TestRemoveInsensitiveAggregateDistinct.java

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#26075	Implement an optimizer rule that rewrites min(distinct x), max(distinct x), arbitrary(distinct x), any_value(distinct x), and similar aggregates to drop the 'distinct' keyword, as these functions are insensitive to duplicates.	✅
#26075	Integrate the optimizer rule into the Presto query planner so that it is applied during query optimization.	✅
#26075	Add tests to verify that the optimizer rule correctly removes 'distinct' from insensitive aggregate functions and does not affect sensitive ones.	✅

Possibly linked issues

• Optimize min(distinct x) to drop 'distinct' #26075: The PR adds RemoveInsensitiveAggregateDistinct rule to optimize distinct-insensitive aggregate functions like min/max, fixing the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[tdcmeehan]

It would be good to think about how we can put this into the function metadata itself, rather than hardcoding this list.