feat: Add TW feature flag for Report Builder Remote UDF

[natashasehgal]

Summary: Add TW feature flag for Facebook internal function - FB Report Builder Remote Function

Differential Revision: D85263402

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Add a new boolean system configuration flag to enable the Facebook Report Builder Remote UDF, including its key definition, default value, and accessor method.

Class diagram for updated SystemConfig with new feature flag

classDiagram
    class SystemConfig {
        +enableVeloxExprSetLogging() bool
        +enableFbRemoteReportBuilderFunction() bool
        +useMmapAllocator() bool
        <<static>> kEnableVeloxTaskLogging : string_view
        <<static>> kEnableVeloxExprSetLogging : string_view
        <<static>> kEnableFbRemoteReportBuilderFunction : string_view
        <<static>> kLocalShuffleMaxPartitionBytes : string_view
        <<static>> kShuffleName : string_view
    }

Loading

File-Level Changes

Change	Details	Files
Define new feature flag key and declare its accessor	Add static constexpr key string for the new flag Declare enableFbRemoteReportBuilderFunction() in SystemConfig	presto-native-execution/presto_cpp/main/common/Configs.h
Integrate feature flag into SystemConfig implementation	Add BOOL_PROP entry with default=true to SystemConfig constructor Implement enableFbRemoteReportBuilderFunction() to return the flag’s value	presto-native-execution/presto_cpp/main/common/Configs.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[aditi-pandit]

@natashasehgal : This flag is for a very specific Meta feature.

It would be great if you'll have a separate Meta internal Config for these and not add to the general Prestissimo SystemConfig.

@amitkdutta : wdyt ? Any chance these config can be kept Meta internal ?

[amitkdutta]

@natashasehgal Lets add this config internally as the config is not used in oss