Enhancements to the presto router ui #24411
Conversation
formatting formatting imports
|
|
prestodb-ci
requested review from
a team,
zuyu and
BryanCutler
and removed request for
a team
|
@auden-woolfson Is there any co-author you need to add to this? |
@ethanyzhang all of these changes were originally committed by Saran and I. I can add him as an author to the commit before merge |
| @@ -45,7 +46,14 @@ export class PageTitle extends React.Component<Props, State> { | |||
| refreshLoop() { | |||
| clearTimeout(this.timeoutId); | |||
| fetch("/v1/info") | |||
| .then(response => response.json()) | |||
| .then(response => { | |||
| if (response.status === 401) { | |||
There was a problem hiding this comment.
Can you explain the logic of handling the 401 response code here?
Can this be done by sending a different URL in the fetch above?
There was a problem hiding this comment.
This handles the case of expired Oauth2 tokens, since we are not adding the Oauth2 functionality yet I will remove this.
| @@ -0,0 +1,58 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Where is this file used? Any corresponding server-side code? I guess on the server-side, the session needs to be cleaned.
There was a problem hiding this comment.
Password authentication is added in a separate PR, can move this into that one
Description
Login/logout capabilities and other enhancements added to the presto-router. Brought from IBM internal router changes